thunderbird-patch-review

Easy-to-use patch review interface for Thunderbird

Contribute: ~marcc/thunderbird-review-plugin@lists.sr.ht

git clone git://mccd.space/thunderbird-patch-review

commit b5b3f807e5f4cb857c8bcd1bcb9bbaabfd0d4aff
parent 3fb59dbcbd1bc4c5b9287e276cad3a050c5b9c55
Author: Pi Agent <agent@pi.local>
Date:   Sat, 18 Jul 2026 22:40:22 +0200

review: send button and confirm dialog always say "Send review"

Drop the singular/plural send-review(s) wording now that the title carries\nthe total patch count and comment count; the button label is just "Send\nreview" in both toolbar and confirm dialog, regardless of how many patches\nare commented.

Diffstat:
M
extension/review/review.js
 | 
14
+++-----------

1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/extension/review/review.js b/extension/review/review.js
@@ -483,12 +483,6 @@ function updateCount() {
   // The title is independent of the button-pluralization below; update it
   // first so a failure in the latter cannot leave the count stale.
   renderSeriesTitle();
-  // One reply per commented patch — pluralize the button to match.
-  const commented = state.series.filter((_, i) => Object.keys(state.comments[i] || {}).length).length;
-  const send = $("#btn-send");
-  if (send.firstChild && send.firstChild.nodeType === 3) {
-    send.firstChild.nodeValue = commented === 1 ? "Send review" : "Send reviews";
-  }
 }
 
 $("#btn-discard").addEventListener("click", async () => {
@@ -583,11 +577,9 @@ function openSendConfirm(mode) {
   const commented = state.series.filter((_, i) =>
     Object.keys(state.comments[i]).length
   ).length;
-  const verbSent = mode === "preview" ? "open in compose" : commented === 1 ? "send review" : "send reviews";
-  $("#send-confirm-title").textContent =
-    mode === "preview" ? "Preview review" : commented === 1 ? "Send review" : "Send reviews";
-  $("#btn-send-confirm").textContent =
-    mode === "preview" ? "Open in compose" : commented === 1 ? "Send review" : "Send reviews";
+  const verbSent = mode === "preview" ? "open in compose" : "send review";
+  $("#send-confirm-title").textContent = mode === "preview" ? "Preview review" : "Send review";
+  $("#btn-send-confirm").textContent = mode === "preview" ? "Open in compose" : "Send review";
   $("#send-confirm-summary").textContent =
     `${commented} of ${n} patch${n === 1 ? "" : "es"} has a comment; ` +
     `click ${verbSent} to continue.`;